bump sw-toolbox and import correct map file #37
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelcobain
changed the title
|
@jkleinsc I had issues on CI with this, rolling back to previous versions of the addon didn't seem to resolve the issue. |
|
What's the plan with getting this merged? At the moment this it breaking my CI and I had to resort to using @miguelcobain 's branch as a dependency. |
|
For now, we can add a fixed version of This will force broccoli-serviceworker to use a previous version. |
|
@miguelcobain thanks for the PR! @erkarl I just saw this now, so I am going to merge it in and push another release. Thanks @gnowoel for the workaround. |
|
Thanks @miguelcobain, @gnowoel & @jkleinsc |
|
@erkarl @miguelcobain, @gnowoel @laantorchaweb New version is now available on npm: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
^3.1.1dependency pulled the recently released3.4.0version.It happens that in that version the map file changed name to
sw-toolbox.js.map.This fixes the dependency version and requires the correct file for that release.
A new release of broccoli-serviceworker should happen with this fix. Current version is broken for anyone that happens to pull sw-toolbox 3.4.0.